-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows build: Add CMakeSettings.json and improve documentation #26
base: master
Are you sure you want to change the base?
Conversation
Having longer instructions for Visual Studio is fine, but adding a subsection would be better, so other users can skip it. |
It seems Visual Studio is in the process of integrating CMake Presets: Sure, we can split the doc into subsections if you prefer. I was just going for the least invasive change. What do you want the sections to be? Just Windows/Linux or do you want to split Windows into VS/non-VS? |
Assuming it belongs in version control, the next questions is: Why would I want presets and why would I want your presets?
Simply add something like |
You don't want my presets but you want reasonable presets. The presets are what gets VS users started the most quickly and without needing to install any dependencies. If a user tweaks their configuration obviously that's going to change the
Ok, I'll push that change a bit later. |
66bc2cd
to
d4d8862
Compare
I added an extra heading as discussed. |
d4d8862
to
bee65ed
Compare
As a follow-up to #19 and #5 here are a few additions that make building hidpp on Windows a bit easier. The
CMakeSettings.json
allows people to open the project folder directly in Visual Studio and start building. I've also updated theREADME.md
with some instructions for building the project and installing the getopt dependency.